interface: deprecate default deposit addresses #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2501babe
force-pushed
the
deprecate-default-deposit
branch
from
3881c86 to
60497d2
Compare
2501babe
force-pushed
the
deprecate-default-deposit
branch
from
60497d2 to
e8ead76
Compare
joncinque
reviewed
Oct 21, 2025
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of nits
program/src/instruction.rs
Outdated
| /// lockup. | ||
| #[deprecated( | ||
| since = "3.0.0", | ||
| note = "Will be removed in a future release; this was intended to support a wallet flow that never materialized." |
Contributor
There was a problem hiding this comment.
nit: can this provide the preferred alternative of creating and delegating a stake account?
program/src/lib.rs
Outdated
| /// user stake before deposit. | ||
| #[deprecated( | ||
| since = "3.0.0", | ||
| note = "Will be removed in a future release; this was intended to support a wallet flow that never materialized." |
Contributor
There was a problem hiding this comment.
nit: same here, can this give the alternative of using any new stake account address instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was a misfeature, i imagined it as a way for wallets to fake a sol-like deposit process (eg, i "deposit sol" every epoch, actually it merges the activated stake from the previous epoch and tees up the current sol for the next) but it is super weird and no one ever understood it. eventually it will be replaced by
DepositSol, but there isnt a reason to wait until then to deprecate this because i seriously doubt anyone even uses it. if they do, they can replace it with any method of choosing a canonical address they likethis is just some ux fluff and the program itself doesnt change, it is entirely unaware of this concept and handles them like any other normal stake account